Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy SampleCount when making a copy of FilamentView #7072

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

patrikhuber
Copy link
Contributor

If that function doesn't copy the sample count, the copied view will not be an exact copy - it'll contain the default sample count (=4), and not the sample count of the view it's copying from.

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes - separate issue not created, just see above problem & fix

Motivation and Context

See above.

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

See above.

Otherwise the copied view will not be an exact copy - it'll contain the default sample count (=4), and not the sample count of the view it's copying from.
Copy link

update-docs bot commented Nov 23, 2024

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@patrikhuber patrikhuber marked this pull request as ready for review November 23, 2024 13:04
Copy link
Member

@ssheorey ssheorey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @patrikhuber Thanks!

@ssheorey ssheorey merged commit 7a1c330 into isl-org:main Dec 18, 2024
28 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants