Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Motivation and Context
This PR introduced
winmode=0
for loading DLLs during import. This however leads to directories added viaos.add_dll_directory
not being considered, when loading DLLs (see here or here). In particular this leads toopen3d/tbb12.dll
not being found.Fix this by going back to the default DLL-search mode (
winmode=None
).In order to still be able to find CUDA-DLLs, that are not part of the open3d-package, search their directory in PATH and explicitly add it to the DLL-search-locations for CUDA-builds.
Note that this PR results in DLLs generally not being searched in
PATH
anymore, when importingopen3d
, as is the default behaviour of Python-packages since 3.8. The exception are CUDA-libraries in the heuristically determined directory. If anyone relies onPATH
being searched, this PR breaks functionality.Checklist:
python util/check_style.py --apply
to apply Open3D code styleto my code.
updated accordingly.
results (e.g. screenshots or numbers) here.
Description