-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix all mingw errors & warnings #411
Conversation
…1(undefined4)' used but never defined
Looks good to me. To match functionality precisely (or at least better), you should add a scope in those instances where a "temporary" object is passed by reference, otherwise the destructor will not be called at the right time. So instead of:
it would have to be:
This most likely won't make a difference, but could theoretically introduce bugs in the "compat" version if not changed. |
Thanks! When I boot my Windows box, I'm going to test building with msys2 and Visual Studio 2019, Thanks for the quick reviews and fast responses! It's really nice to have somebody on top of things. |
When building with mingw gcc 10 from ubuntu 22.04, I saw a couple more warnings.
In the last 2 commits, I also fixed the "inline function used but not defined warning".
If those decrease accuracy, perhaps these aren't inlined in the first place?
(I did not yet test the resulting exe + dll on Windows)