Fix user renewals for users without former plast member role #2800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaksymLiaskovskyi
approved these changes
Sep 6, 2022
Serhii-Buniak
approved these changes
Sep 6, 2022
tvardero
reviewed
Sep 6, 2022
| @@ -113,11 +113,12 @@ public async Task<CityMembersDto> RenewFormerMemberUserAsync(UserRenewalDto user | |||
| var cityId = userRenewal.CityId; | |||
| var user = await _userManager.FindByIdAsync(userId); | |||
|
|
|||
| if (!await _userManager.IsInRoleAsync(user, Roles.FormerPlastMember)) | |||
| throw new ArgumentException("User is not Former-Member", nameof(userRenewal)); | |||
| if (await _userManager.IsInRoleAsync(user, Roles.FormerPlastMember)) | |||
There was a problem hiding this comment.
throw наверняка подразумевал, что начиная с 122 строки дальше код выполняться не будет.
Твои изменения безопасны?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2772