Increase length of fields in Profile model #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whooaami
approved these changes
Nov 15, 2023
ProDG
reviewed
Nov 16, 2023
profiles/models.py
Outdated
| @@ -65,7 +65,7 @@ class Profile(models.Model): | |||
| region = models.CharField( | |||
| max_length=128, choices=Region.choices, default=None, null=True | |||
| ) | |||
| common_info = models.CharField(max_length=255, default=None, null=True) | |||
| common_info = models.CharField(max_length=2000, default=None, null=True) | |||
There was a problem hiding this comment.
For texts > 255 chars I'd recommend to use models.TextField(validators=[MaxLengthValidator(2000)], null=True).
CharField translates into varchar PostgreSQL data type, which is fixed length, i.e. each row in the table will take 2k of disk space, even if the field is empty or contains just a couple of chars. TextField translates in dynamic-width data type.
ProDG
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Length of specified fields in Profile model increased:
name - to 100 characters;
common_info - to 2000 characters.