Feature/issue 1797 #1458
Open
Feature/issue 1797 #1458
+26
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sashapanasiuk5
requested review from
ulyasaur,
Michael-Kolpakov and
darkravchuk
|
Michael-Kolpakov
approved these changes
Oct 25, 2024
Michael-Kolpakov
approved these changes
Oct 25, 2024
| @@ -62,6 +63,12 @@ const InterestingFactsAdminModal = ({ fact, open, setModalOpen, onChange }: Prop | |||
| setFileList([]); | |||
| }; | |||
|
|
|||
| const validateFact = uniquenessValidator( | |||
| () => (factsStore.getFactArray.map( (fact) => fact.title)), | |||
| () => (fact?.title), | |||
There was a problem hiding this comment.
Is it really necessary to wrap the right side of the expression in parentheses?
ulyasaur
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github
Summary of issue
Currently, when an admin user adds a Wow-Fact or Chronology to a new street code using the respective modal window, the system displays a confirmation message indicating that the new entry has been added successfully. However, the modal window remains open with all fields still populated.
Summary of change