Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plenty of work has been done with the tests (someone else needs to finish them :(( ) #1466

Open
wants to merge 1 commit into
base: release/1.1.0
Choose a base branch
from
Open

Plenty of work has been done with the tests (someone else needs to finish them :(( ) #1466

wants to merge 1 commit into from

Conversation

Michael-Kolpakov
Copy link
Contributor

Ticket

Code reviewers

Summary of issue

  • It was needed to write tests for the MainNewStreetcode component.

Summary of change

  • The tests are written, but not completely. There are problems with running them properly and it's need some help from other developers to finish them.

CHECK LIST

  • СI passed
  • Сode coverage >=95%
  • PR is reviewed manually again (to make sure you have 100% ready code)
  • All reviewers agreed to merge the PR
  • I've checked new feature as logged in and logged out user if needed
  • PR meets all conventions

@Michael-Kolpakov Michael-Kolpakov self-assigned this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sashapanasiuk5 sashapanasiuk5 Awaiting requested review from sashapanasiuk5

@ulyasaur ulyasaur Awaiting requested review from ulyasaur

@darkravchuk darkravchuk Awaiting requested review from darkravchuk

At least 3 approving reviews are required to merge this pull request.

Assignees

@Michael-Kolpakov Michael-Kolpakov

Labels
do not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Michael-Kolpakov