add unlighthouse scan after staging #996
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NVMakarenko
requested review from
olexandervanzuriak,
DanielVajnagi,
SleekMutt,
KseniaGovorun,
ktpe and
loqimean
2 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #996 +/- ##
===========================================
+ Coverage 91.82% 91.92% +0.09%
===========================================
Files 74 75 +1
Lines 1052 1065 +13
===========================================
+ Hits 966 979 +13
Misses 86 86 ☔ View full report in Codecov by Sentry. |
loqimean
requested changes
Dec 1, 2024
.github/workflows/cd.yml
Outdated
Comment on lines
34
to
35
| - name: Set up Unlighthouse Scan | ||
| run: npm install -g @unlighthouse/cli puppeteer |
There was a problem hiding this comment.
this report generation should be outside deploy action, with the same conditions, but that's another thing tather deploy
spec/lib/convert_json_to_csv_spec.rb
Outdated
|
|
||
| describe ".perform" do | ||
| it "converts JSON to CSV" do | ||
| ConvertJsonToCsv.perform(input_file, output_file) |
spec/lib/convert_json_to_csv_spec.rb
Outdated
| describe ".perform" do | ||
| it "converts JSON to CSV" do | ||
| ConvertJsonToCsv.perform(input_file, output_file) | ||
| csv_content = CSV.read(output_file, headers: true) |
app/lib/convert_json_to_csv.rb
Outdated
|
|
||
| class ConvertJsonToCsv | ||
| def self.perform(input_file, output_file) | ||
| json_data = JSON.parse(File.read(input_file)) |
There was a problem hiding this comment.
Suggested change
| json_data = JSON.parse(File.read(input_file)) | |
| json_data = JSON.parse(File.read(input_file)) | |
app/lib/convert_json_to_csv.rb
Outdated
Comment on lines
4
to
6
| class ConvertJsonToCsv | ||
| def self.perform(input_file, output_file) | ||
| json_data = JSON.parse(File.read(input_file)) |
There was a problem hiding this comment.
write it as service object
app/lib/convert_json_to_csv.rb
Outdated
Comment on lines
1
to
2
| require "json" | ||
| require "csv" |
There was a problem hiding this comment.
that should already present
app/lib/convert_json_to_csv.rb
Outdated
| def self.perform(input_file, output_file) | ||
| json_data = JSON.parse(File.read(input_file)) | ||
| CSV.open(output_file, "w", write_headers: true, headers: json_data.first.keys) do |csv| | ||
| json_data.each { |row| csv << row.values } |
There was a problem hiding this comment.
that would be fine to make link available to open
bin/convert_json_to_csv.rb
Outdated
1 task
1 task
SleekMutt
approved these changes
Dec 1, 2024
loqimean
force-pushed
the
develop
branch
3 times, most recently
from
03a3caf to
7d2dc81
Compare
loqimean
requested changes
Dec 4, 2024
| end | ||
|
|
||
| it "initializes and calls the instance with the provided arguments" do | ||
| result = ConvertJsonToCsvService.call(input_file, output_file) |
There was a problem hiding this comment.
ну я ж вам і не раз казав, НІКОЛИ не пишіть локал змінні в тестах
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dev
Project
Code reviewers
Second Level Review
Summary of issue
Unlighthouse scanning should start after deployment to the stage. Reports upload as action artifacts.
Summary of change
CHECK LIST