Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corretto componente dimmer #1091

Merged
merged 4 commits into from
Sep 10, 2024
Merged

Corretto componente dimmer #1091

merged 4 commits into from
Sep 10, 2024

Conversation

Virtute90
Copy link
Contributor

Fixes #1088

PR Checklist

  • My branch is up-to-date with the Upstream main branch.
  • The unit tests pass locally with my changes (if applicable).
  • I have added tests that prove my fix is effective or that my feature works (if applicable).
  • I have added necessary documentation (if appropriate).

Short description of what this resolves:

Aggiornato componente Dimmer con risoluzione del problema linkato.

Changes proposed in this Pull Request:

  • Correzione problema trasparenza (mancava la classe .fade)
  • Rimozioni colori non necessari dell'interfaccia
  • Aggiunto parametro show per mostrare il dimmer o no, non era presente ?!
  • Aggiornata documentazione:
    • Aggiunto esempio interattivo
    • rimozione componenti ed esempi non necessari.
    • Aggiunta classe .dimmable
  • Aggiornato test

Copy link

vercel bot commented Aug 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
design-react-kit ✅ Ready (Inspect) Visit Preview Aug 29, 2024 7:19am

@Virtute90 Virtute90 changed the title Feat/dimmer Corretto componente dimmer Aug 20, 2024
@Fupete Fupete requested a review from astagi August 23, 2024 15:02
@astagi
Copy link
Member

astagi commented Aug 28, 2024

@Virtute90 thanks for this PR! is it possible to resolve conflicts? Thank you!

@Virtute90
Copy link
Contributor Author

@Virtute90 thanks for this PR! is it possible to resolve conflicts? Thank you!

Done!

@astagi astagi merged commit 548608a into italia:main Sep 10, 2024
5 checks passed
@Virtute90 Virtute90 deleted the feat/dimmer branch September 12, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Componente Dimmer: la variante primary non è "trasparente"
2 participants