Skip to content

Commit

Permalink
updating the _use_volume setting to false for new agent installs
Browse files Browse the repository at this point in the history
  • Loading branch information
its-a-feature committed Nov 27, 2024
1 parent ec2078d commit b4aa736
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 2 deletions.
7 changes: 7 additions & 0 deletions Mythic_CLI/Changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,13 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## 0.3.7 -

### Changed

- Updated the default value for an installed service's *_use_volume setting to be `false` instead of `true`
- too many people were having issues with lingering volumes, so it's better to have people explicitly set this if they need it

## 0.3.6 - 2024-11-25

### Changed
Expand Down
2 changes: 1 addition & 1 deletion Mythic_CLI/src/cmd/config/vars.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@ package config

var (
// Version Mythic CLI version
Version = "v0.3.6"
Version = "v0.3.7"
)
2 changes: 1 addition & 1 deletion Mythic_CLI/src/cmd/internal/installservice.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ func InstallFolder(installPath string, overWrite bool, keepVolume bool, installU
for key, val := range latestVersion {
config.SetNewConfigStrings(fmt.Sprintf("%s_remote_image", key), val)
if !config.GetMythicEnv().InConfig(fmt.Sprintf("%s_use_volume", key)) {
config.SetNewConfigStrings(fmt.Sprintf("%s_use_volume", key), "true")
config.SetNewConfigStrings(fmt.Sprintf("%s_use_volume", key), "false")
}
if !config.GetMythicEnv().InConfig(fmt.Sprintf("%s_use_build_context", key)) {
config.SetNewConfigStrings(fmt.Sprintf("%s_use_build_context", key), "false")
Expand Down

0 comments on commit b4aa736

Please sign in to comment.