Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

count as TP only when there's at least 10% overlap #14

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

naga-karthik
Copy link
Member

@naga-karthik naga-karthik commented Oct 18, 2024

This PR updates the lesion_f1_score metric by modifying the condition for a "true positive" prediction. Previously, it was this here:

Masks are considered true positives if at least one voxel overlaps between the truth and the prediction.

but taking only 1 voxel might be a bit too less so I updated the code to consider at least a 10% overlap to assign a prediction as "True Positive". Note that this is in line with how anima also assigns true positives.

output of animaSegPerfAnalyzer -h
   -z <double>,  --MaxFalsePositiveRatioModerator <double>
     Percentage of the regions overlapping the tested lesion is not too
     much outside of this lesion. (default 0.65)

   -y <double>,  --MaxFalsePositiveRatio <double>
     Maximum of false positive ratio to limit the detection of a lesion in
     GT if a lesion in the image is too big. (default 0.7)

   -x <double>,  --MinOverlapRatio <double>
     Minimum overlap ratio to say if a lesion of the GT is detected.
     (default 0.10)

   -v <double>,  --MinLesionVolume <double>
     Min volume of lesion for "Lesions detection metrics" in mm^3 (default
     3mm^3).

I did not touch the False Positive part yet.

Any thoughts, @valosekj @plbenveniste ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant