count as TP only when there's at least 10% overlap #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
lesion_f1_score
metric by modifying the condition for a "true positive" prediction. Previously, it was this here:but taking only 1 voxel might be a bit too less so I updated the code to consider at least a 10% overlap to assign a prediction as "True Positive". Note that this is in line with how
anima
also assigns true positives.output of animaSegPerfAnalyzer -h
I did not touch the False Positive part yet.
Any thoughts, @valosekj @plbenveniste ?