searchMoreWithId functionality to SOAP interface #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vlouvet
commented
Dec 25, 2023
vlouvet
commented
- formatted the code from CameronLofy:main branch using Black, and confirmed it passes tests, and pre-commit checks.
add REST API example in Programmatic use section
Added searchMoreWithId function in SOAP interface to be able to paginate results when more than 1000 returns. See the following docs for more information. https://docs.oracle.com/en/cloud/saas/netsuite/ns-online-help/section_N3523074.html#searchMoreWithId
Added searchMoreWithId function in SOAP interface to be able to paginate results when more than 1000 returns. See the following docs for more information. https://docs.oracle.com/en/cloud/saas/netsuite/ns-online-help/section_N3523074.html#searchMoreWithId
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #71 +/- ##
==========================================
+ Coverage 35.71% 35.80% +0.08%
==========================================
Files 25 25
Lines 1064 1067 +3
==========================================
+ Hits 380 382 +2
- Misses 684 685 +1 ☔ View full report in Codecov by Sentry. |
|
@vlouvet flake8 check is still failing, can you resolve? |
build(deps): update httpx requirement from ~0.25 to >=0.25,<0.27 (jacobsvante#70)
|
@iloveitaly I will create a separate PR to add robust tests to the soap and rest API - but all checks passing now. |
|
@iloveitaly this is ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.