Fix issue preventing DEF 14A filings from downloading

[jadchaar]

It seems to be an issue with the use of rstrip when cleaning up the amends suffix here:

sec-edgar-downloader/sec_edgar_downloader/_orchestrator.py

Line 80 in b919ddd

form.rstrip(AMENDS_SUFFIX) != download_metadata.form

Upon testing, it appears that the use of rstrip is leading to some unintended issues when a filing type ends with any type of A:

>>> test_no_amend = "DEF 14A"
>>> test_no_amend.rstrip("/A")
DEF 14
>>> test_amend = "DEF 14A/A"
>>> test_amend.rstrip("/A")
DEF 14

Solution is to switch from rstrip to [:-2] if an amend is detected. When an amend is not detected, the form will be used as-is and not manipulated.

Closes: #129

[codecov]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b919ddd) 100.00% compared to head (42ee0c3) 100.00%.

Additional details and impacted files

@@            Coverage Diff            @@
##            master      #130   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          218       220    +2     
  Branches        30        30           
=========================================
+ Hits           218       220    +2     

Files	Coverage Δ
sec_edgar_downloader/_orchestrator.py	100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.