youtube: Normalize timestamps to seconds #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leungbk
force-pushed
the
youtube-normalize-timestamps
branch
from
4f54b51 to
a1f1e48
Compare
|
@jakemiki would you mind taking a look? |
|
Hi, sorry for taking so long. Just out of curiosity, where do you get YouTube links with timestamps in this format? Sharing from the website creates the one currently supported. Anyway, looks good to me. |
No problem, thanks for merging!
What do you mean by "this format"? I've seen people posting into Twitch chats YouTube links with timestamps in hours/minutes/seconds. BTW, if you have some time, would you be willing to explain to me the behavior I noticed in #11? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to fix a problem where enqueuing https://www.youtube.com/watch?v=6zY89ZLDZVo&t=5s will start at the beginning of the video rather than at the specified timestamp.
However, I do not know how to test because of a problem I encountered, described in #11.