fix: remove cuda toolkit error message and bring back incremental model import #3997
+19
−48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This PR removes the irrelevant error message about missing CUDA toolkit dependencies since it’s now shipped by default. Bring back the legacy incremental model import naming convention.
Changes made
1.
useDropModelBinaries.ts
:2.
useImportModel.ts
:useAtomValue
was imported to access the atom state.downloadedModelsAtom
was added to the imports, which enables tracking of already downloaded models.incrementalModelName
, was introduced to handle naming conflicts. This function ensures that any model name duplicates are resolved by appending a number to the model's name.incrementalModelName
for unique identification.useDropModelBinaries.ts
was applied, where spaces in model names are removed.3.
LoadModelError/index.tsx
:Overall, these changes focus on ensuring unique model name identification, simplifying error handling by removing specific GPU-related messages, and cleaning up file name processing.