Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: syntax highlight configurations that made everything dark #4223

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

louis-jan
Copy link
Contributor

@louis-jan louis-jan commented Dec 5, 2024

Describe Your Changes

CleanShot 2024-12-05 at 08 50 40

CleanShot 2024-12-05 at 09 16 28

Changes made

The given git diff shows changes made to the MarkdownTextMessage.tsx component. Here's a summary of the modifications:

  1. Import Statements:

    • The latex language import from highlight.js has been removed.
    • The CSS import for katex has been rearranged, but it's effectively unchanged.
    • A new CSS import for highlight.js styles (atom-one-dark.css) has been added, which implies a change in the highlighted code's visual appearance.
  2. Rehype Plugins Configuration:

    • The configuration for rehypeHighlight has been simplified. The previous custom configuration that included the latex language, no subset, and plain text options has been replaced with a default setup by removing the custom configuration object.

These changes likely simplify the markdown rendering logic and improve code syntax highlighting by using the default language setup and adding dark-themed styling for code blocks.

@louis-jan louis-jan requested a review from a team December 5, 2024 01:52
@github-actions github-actions bot added the type: bug Something isn't working label Dec 5, 2024
Copy link
Contributor

github-actions bot commented Dec 5, 2024

Barecheck - Code coverage report

Total: 69.26%

Your code coverage diff: 0.00% ▴

Uncovered files and lines
FileLines
web/screens/Thread/ThreadCenterPanel/TextMessage/MarkdownTextMessage.tsx22, 25, 33-36, 38, 42, 49-51, 57, 60-62, 64, 69-70, 73, 123, 125-126, 131-132, 191

@louis-jan louis-jan merged commit e56b3e4 into main Dec 5, 2024
11 checks passed
@louis-jan louis-jan deleted the fix/syntax-highlight-correction branch December 5, 2024 02:19
@github-actions github-actions bot added this to the v0.5.11 milestone Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants