feat: add chat width setting option for thread #4278
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
explanation of the changes:
TopPanel/index.tsx:
setSelectedSetting
function's argument was changed from'Appearance'
to'Preferences'
.Setting.atom.ts:
CHAT_WIDTH
.chatWidthAtom
with a default value of'full'
.Images:
compact-width.png
andfull-width.png
.Appearance/index.tsx:
chatWidthAtom
.chatWidthOption
containing options for chat width.chatWidthAtom
.SettingDetail/index.tsx:
'Appearance'
to'Preferences'
.Settings/index.tsx:
'Appearance'
to'Preferences'
in theSettingScreenList
.TextMessage/index.tsx:
chatWidthAtom
and used its value to conditionally apply styles. Themax-w-[700px]
class is applied ifchatWidth
is'compact'
.Overall, these changes introduce a new preference for setting the chat width, adjust visual components to support this preference, and rename aspects of the settings from "Appearance" to "Preferences".
In the future, we need to update the design. The basic design rules are as follows:
Detailed Explanation:
Good example thumbnail selection
cc @dan-homebrew @imtuyethan
Fixes Issues
Self Checklist