Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: starter screen layout #4279

Merged
merged 1 commit into from
Dec 17, 2024
Merged

fix: starter screen layout #4279

merged 1 commit into from
Dec 17, 2024

Conversation

urmauur
Copy link
Member

@urmauur urmauur commented Dec 17, 2024

Describe Your Changes

Before
CleanShot 2024-12-17 at 09 46 55

After
CleanShot 2024-12-17 at 09 47 10

  1. CenterPanelContainer Component:

    • A new type Props is introduced to include an optional property isShowStarterScreen, in addition to PropsWithChildren.
    • The CenterPanelContainer function is updated to accept isShowStarterScreen as a prop.
    • The inline styling for the div element is updated to account for isShowStarterScreen. The condition for maxWidth now additionally checks if !isShowStarterScreen.
  2. OnDeviceStarterScreen Component:

    • A new type Props is introduced with an optional property isShowStarterScreen.
    • The OnDeviceStarterScreen function is updated to accept isShowStarterScreen as a prop.
    • The CenterPanelContainer component within the OnDeviceStarterScreen component is now called with the isShowStarterScreen prop passed down to it.
  3. Thread Component:

    • The OnDeviceStarterScreen is now called with the isShowStarterScreen prop passed to it, ensuring that the state is appropriately passed downstream when ThreadPanels is memoized and rendered based on the isShowStarterScreen condition.

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@urmauur urmauur added the type: bug Something isn't working label Dec 17, 2024
@urmauur urmauur added this to the v0.5.12 milestone Dec 17, 2024
@urmauur urmauur requested a review from louis-jan December 17, 2024 02:55
@urmauur urmauur self-assigned this Dec 17, 2024
Copy link
Contributor

Barecheck - Code coverage report

Total: 69.22%

Your code coverage diff: 0.00% ▴

Uncovered files and lines
FileLines
web/screens/Thread/ThreadCenterPanel/ChatBody/OnDeviceStarterScreen/index.tsx67, 95, 101, 125, 146-147, 149, 172, 181, 183, 211, 234, 236, 267, 293, 299, 303, 308-309, 311, 340

Copy link
Contributor

This is the build for this pull request. You can download it from the Artifacts section here: Build URL.

@urmauur urmauur merged commit 0164db2 into dev Dec 17, 2024
21 checks passed
@urmauur urmauur deleted the fix/starter-screen-layout branch December 17, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants