Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: model parameters for inference extensions #935

Merged
merged 3 commits into from
Dec 11, 2023
Merged

fix: model parameters for inference extensions #935

merged 3 commits into from
Dec 11, 2023

Conversation

hiro-v
Copy link
Contributor

@hiro-v hiro-v commented Dec 10, 2023

Fix #932

@hiro-v hiro-v added P1: important Important feature / fix type: bug Something isn't working labels Dec 10, 2023
@hiro-v hiro-v added this to the v0.5.0 milestone Dec 10, 2023
@hiro-v hiro-v requested a review from a team December 10, 2023 13:17
@hiro-v hiro-v self-assigned this Dec 10, 2023
freelerobot
freelerobot approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@freelerobot freelerobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this

@hiro-v hiro-v merged commit 79b9997 into main Dec 11, 2023
2 checks passed
@hiro-v hiro-v deleted the fix/inference_model_parameters branch December 11, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-jan louis-jan louis-jan approved these changes

@freelerobot freelerobot freelerobot approved these changes

@namchuai namchuai namchuai approved these changes

Assignees

@hiro-v hiro-v

Labels
P1: important Important feature / fix type: bug Something isn't working
Projects
Jan & Cortex
Archived in project
Milestone
Jan Windows MVP
Development

Successfully merging this pull request may close these issues.

bug: Remote models not taking model parameters
4 participants
@hiro-v @namchuai @freelerobot @louis-jan