Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops (serial) compile times from ~980s to ~740 seconds. This is important not just for our dev experience, but because we'll ultimately be including more of these header during runtime and startup. We need them to be as light as possible. I used clang build analyzer for figuring out the most important things to tackle. There's a lot more which can be done (we can definitely get under 500s), but for now this PR includes:
static_object
with distinct object typesmagic_enum
in favor ofconstexpr
fns