-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update MultiSelect.svelte for Svelte5 compatibility #293
Conversation
ideally, i'd prefer to update package deps and unit tests to Svelte 5 in one go. that requires an update to mdsvexamples and fixing how unit tests create component instances const select = new MultiSelect({
target: document.body,
props: { options },
})
|
bump unit tests to svelte 5 later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
svelte 5 compatibility is time sensitive so merging as is since upstream blockers could take months to resolve or might even require a docs rework since mdsvexamples
looks to be unmaintained
In fact my idea was not to update deps to Svelte 5 already, but just make it work for people who can't wait, solving the build issues. I'm already using it in production and works just fine. |
that would be great, looking forward to that PR! 👍 could you give v11.0.0-rc.1 a try and let me know how it goes? |
Looks good to me! |
Closes #281
Summary of major changes
Todos