Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename acr plugin directory references #1711

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

04kash
Copy link
Member

@04kash 04kash commented Sep 30, 2024

Description

This PR fixs configuration to reflect changes from #1701.

Which issue(s) does this PR fix

  • Fixes #?

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@04kash
Copy link
Member Author

04kash commented Sep 30, 2024

Opened a PR here: #1712 to fix the 3scale path

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1711!

1 similar comment
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1711!

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1711!

Signed-off-by: Kashish Mittal <kmittal@redhat.com>
Signed-off-by: Kashish Mittal <kmittal@redhat.com>
Signed-off-by: Kashish Mittal <kmittal@redhat.com>
Copy link

sonarcloud bot commented Sep 30, 2024

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1711!

@kadel
Copy link
Member

kadel commented Oct 1, 2024

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 1, 2024
Copy link

openshift-ci bot commented Oct 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 1, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 619414b into janus-idp:main Oct 1, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants