Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply preview setting to ruff formatter #108

Closed
wants to merge 1 commit into from

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Jan 24, 2024

It is currently required by the following setting:

quote-style = "preserve"

From https://docs.astral.sh/ruff/settings/#format-quote-style:

  • preserve (preview only): Keeps the existing quote character. We don't recommend using this option except for projects that already use a mixture of single and double quotes and can't migrate to using double or single quotes.

Fixes #99 (comment).

It is currently required by the following setting:
	quote-style = "preserve"
@jaraco
Copy link
Owner

jaraco commented Feb 6, 2024

I found the same issue. I was noticing that since we hadn't (yet) enabled formatting in the test suite, it was not breaking not to have this setting. I was hand-adding ruff format --preview when running locally and hoping the preview flag would be unnecessary before I had to add it, but I was recently employing it in an editor and had the same issue, so I made the same change in 29e5d34.

@jaraco jaraco closed this Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants