Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

These keys must be kept in sync #120

Conversation

DimitriPapadopoulos
Copy link
Contributor

If ruff.toml exists, the requires-python key is currently not taken into account - not in pyproject.toml and even less in setup.cfg.

See:
astral-sh/ruff#10299

Fixes #119.

If `ruff.toml` exists, the `requires-python` key is currently not taken
into account - not in `pyproject.toml` and even less in `setup.cfg`.

See:
astral-sh/ruff#10299
@DimitriPapadopoulos DimitriPapadopoulos force-pushed the requires-python_target-version branch 2 times, most recently from 3cd8d0b to 9a8e860 Compare April 15, 2024 13:14
@DimitriPapadopoulos
Copy link
Contributor Author

Not sure what the CI error is about:

WARNING: autodoc: failed to import module 'PROJECT'; the following exception was raised:
No module named 'PROJECT'

I would need more detailed Sphinx logs to infer what the problem is.

@jaraco
Copy link
Owner

jaraco commented Apr 15, 2024

As mentioned in #120 - let's work to move the metadata to pyproject.toml instead (#121). Thanks for this suggestion though.

@jaraco jaraco closed this Apr 15, 2024
@DimitriPapadopoulos DimitriPapadopoulos deleted the requires-python_target-version branch April 15, 2024 14:38
@bswck
Copy link
Contributor

bswck commented Apr 15, 2024

Not sure what the CI error is about:

WARNING: autodoc: failed to import module 'PROJECT'; the following exception was raised:
No module named 'PROJECT'

I would need more detailed Sphinx logs to infer what the problem is.

@DimitriPapadopoulos You can ignore it. It's an expected error to get, see also https://blog.jaraco.com/skeleton/#continuous-integration-mismatch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

target-version in ruff.toml
3 participants