Skip to content

Commit

Permalink
Allow shortcuts to be empty and to have win/mac/linux-specific keys.
Browse files Browse the repository at this point in the history
Phosphor allows shortcuts to be empty, and it’s the only way to have platform-specific shortcuts (define keys to be [], and the platform keys to be something specific).

See phosphorjs/phosphor#438 for some discussion.
  • Loading branch information
jasongrout committed Oct 12, 2019
1 parent e04e3af commit 5b722dc
Showing 1 changed file with 12 additions and 1 deletion.
13 changes: 12 additions & 1 deletion packages/shortcuts-extension/schema/shortcuts.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,18 @@
"command": { "type": "string" },
"keys": {
"items": { "type": "string" },
"minItems": 1,
"type": "array"
},
"winKeys": {
"items": { "type": "string" },
"type": "array"
},
"macKeys": {
"items": { "type": "string" },
"type": "array"
},
"linuxKeys": {
"items": { "type": "string" },
"type": "array"
},
"selector": { "type": "string" }
Expand Down

0 comments on commit 5b722dc

Please sign in to comment.