bugfix: fix tooltip in the checkBox and RadioButton #5623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boutinb
force-pushed
the
fixTooltips
branch
2 times, most recently
from
224d254
to
eb7804b
Compare
|
@shun2wang There was already a tooltip in jaspControl but it did not work. Handling attached property in c++ can be tricky: the attached property can be called directly if there is an import statement in the QML file without label. But by setting the tooltip directly in the MouseArea it works perfectly. |
|
I have added also a test in the jaspTestModule. |
|
Great! so then we should remove all tooltip settings from other jaspControls component and just reuse it from C++ side? I rebased this PR to head. |
shun2wang
force-pushed
the
fixTooltips
branch
from
eb7804b
to
7fe9e5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://github.com/jasp-stats/INTERNAL-jasp/issues/2525
Fixes: https://github.com/jasp-stats/INTERNAL-jasp/issues/2366
The reason is that sometimes the checkbox and radioButton cannot actually detect the mouse hover event.