Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving "Garbage collection" article #3723

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

TurekBot
Copy link

I noticed a thing or two that could be better, so I went ahead and fixed them myself.

For changes that seem less obvious, I explain in the commit message. However, maybe something that was obvious to me is not obvious to you, so feel free to ask for further explanation.

Suggestions are welcome!

@javascript-translate-bot javascript-translate-bot added the review needed Review needed, please approve or request changes label Jul 21, 2024
@javascript-translate-bot javascript-translate-bot requested a review from a team July 21, 2024 04:15
Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tutorial have many grammar issues.
I'd focus there, actual errors
Still,
There are many good PR piling up...

Lack of reviewers

...

Backticks are there on purpose. They format the view (usually reserved words),resuling in a highlighted text, a quoted "user" in this case.

Why not dashes?
They are perfect. Allowed and clearer.
I love them so much that I leave them even in Spanish where they are not allowed. Take that, Real Academia Española.

"anymore", maybe, I dont know if mandatory

"the" and "-s" added,
some simplifications,
Look like real fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review needed Review needed, please approve or request changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants