Ninja code #182
Open
Ninja code #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odsantos
requested changes
Dec 30, 2020
There was a problem hiding this comment.
Hi @Mr-Saxobeat , would you please comment or consider these changes? Thank you.
|
|
||
|
|
||
| ```quote author="Confucius (Analects)" | ||
| Learning without thought is labor lost; thought without learning is perilous. | ||
| ```quote author="Confúcio" |
There was a problem hiding this comment.
Suggested change
| ```quote author="Confúcio" | |
| ```quote author="Confúcio (Analects)" |
Hi, that seems to be missing here.
| ``` | ||
|
|
||
| Programmer ninjas of the past used these tricks to sharpen the mind of code maintainers. | ||
| Programadores ninjas do passado usavam truques para moldar a mente dos mantenedores de códigos. |
There was a problem hiding this comment.
Suggested change
| Programadores ninjas do passado usavam truques para moldar a mente dos mantenedores de códigos. | |
| Programadores ninjas do passado usavam estes truques para moldar a mente dos mantenedores de código. |
| i = i ? i < 0 ? Math.max(0, len + i) : i : 0; | ||
| ``` | ||
|
|
||
| Cool, right? If you write like that, a developer who comes across this line and tries to understand what is the value of `i` is going to have a merry time. Then come to you, seeking for an answer. | ||
| Lega, né? Se você escrever dessa forma, um desenvolvedor que passar por essa linha e tentar entender qual o valor de `i` irá gastar um bom tempo. E então irá até você pedindo uma resposta. |
There was a problem hiding this comment.
Suggested change
| Lega, né? Se você escrever dessa forma, um desenvolvedor que passar por essa linha e tentar entender qual o valor de `i` irá gastar um bom tempo. E então irá até você pedindo uma resposta. | |
| Legal, né? Se você escrever dessa forma, um desenvolvedor que passar por essa linha e tentar entender qual o valor de `i` irá gastar um bom tempo. E então irá até você pedindo uma resposta. |
|
|
||
| Tell them that shorter is always better. Initiate them into the paths of ninja. | ||
| Diga a eles que o curto é sempre melhor. Introduza eles ao caminho do ninja. |
There was a problem hiding this comment.
Suggested change
| Diga a eles que o curto é sempre melhor. Introduza eles ao caminho do ninja. | |
| Diga a eles que o curto é sempre melhor. Introduza eles no caminho do ninja. |
|
|
||
| ## One-letter variables | ||
| ## Variáveis de letra única |
There was a problem hiding this comment.
Suggested change
| ## Variáveis de letra única | |
| ## Variáveis de uma letra |
| The Dao hides in wordlessness. Only the Dao is well begun and well | ||
| completed. | ||
| ```quote author="Lao Zi (Tao Te Ching)" | ||
| O Caminho é invisível e não tem nome. |
There was a problem hiding this comment.
Suggested change
| O Caminho é invisível e não tem nome. | |
| O Dao se esconde na ausência de palavras. Apenas o Dao está bem iniciado e bem | |
| concluído. |
|
|
||
| ```quote author="Guan Yin Zi" | ||
| When in the light, can't see anything in the darkness.<br> | ||
| When in the darkness, can see everything in the light. | ||
| Quando na luz, não podes ver nada na escuridão. |
There was a problem hiding this comment.
Suggested change
| Quando na luz, não podes ver nada na escuridão. | |
| Quando na luz, não pode ver nada na escuridão.<br> |
| When in the light, can't see anything in the darkness.<br> | ||
| When in the darkness, can see everything in the light. | ||
| Quando na luz, não podes ver nada na escuridão. | ||
| Quando na escuridão, não podes ver nada na luz. |
There was a problem hiding this comment.
Suggested change
| Quando na escuridão, não podes ver nada na luz. | |
| Quando na escuridão, pode ver tudo na luz. |
| ```quote author="Confucius (Analects)" | ||
| Learning without thought is labor lost; thought without learning is perilous. | ||
| ```quote author="Confúcio" | ||
| Estudo sem pensamento é trabalho perdido; pensamento sem estudo é perigoso. |
There was a problem hiding this comment.
Suggested change
| Estudo sem pensamento é trabalho perdido; pensamento sem estudo é perigoso. | |
| Aprender sem pensar é trabalho perdido; pensar sem aprender é perigoso. |
| The great Tao flows everywhere,<br> | ||
| both to the left and to the right. | ||
| ```quote author="Lao Zi (Tao Te Ching)" | ||
| O Grande Caminho é vasto |
There was a problem hiding this comment.
Suggested change
| O Grande Caminho é vasto | |
| O grande Tao flui por toda parte,<br> |
|
Please make the requested changes. After it, add a comment "/done". |
|
|
|
Hi @Mr-Saxobeat , Are you still working on this? If you're not available, I might be able to release it for another person. Thanks, |
|
Hi @Mr-Saxobeat , This PR also has conflicts after updating the article to the English version. Thanks, |
|
@odsantos, @jonnathan-ls, @Peruibeloko, we need to resolve the conflicts of this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translates "Ninja code" article.