Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async iteration and generators #418

Merged
merged 3 commits into from
Mar 6, 2024
Merged

Async iteration and generators #418

merged 3 commits into from
Mar 6, 2024

Conversation

danilolmc
Copy link
Contributor

No description provided.

@javascript-translate-bot javascript-translate-bot requested a review from a team January 8, 2024 15:21
@javascript-translate-bot javascript-translate-bot mentioned this pull request Jan 8, 2024
Open
nazarepiedady
nazarepiedady requested changes Feb 28, 2024
View reviewed changes
Copy link
Member

@nazarepiedady nazarepiedady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danilolmc, could you update your pull request?

1-js/12-generators-iterators/2-async-iterators-generators/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@nazarepiedady
Copy link
Member

@Peruibeloko, could you do the honours?

Peruibeloko
Peruibeloko suggested changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@Peruibeloko Peruibeloko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Além dos comentários que deixei, senti falta de conectores como artigos em diversos pontos, como "o await", "o - async", etc. mas não acho que sejam problemas grandes demais para prejudicar a compreensão do texto

1-js/12-generators-iterators/2-async-iterators-generators/head.html Outdated Show resolved Hide resolved
1-js/12-generators-iterators/2-async-iterators-generators/article.md Outdated Show resolved Hide resolved
1-js/12-generators-iterators/2-async-iterators-generators/article.md Outdated Show resolved Hide resolved
1-js/12-generators-iterators/2-async-iterators-generators/article.md Outdated Show resolved Hide resolved
1-js/12-generators-iterators/2-async-iterators-generators/article.md Outdated Show resolved Hide resolved
1-js/12-generators-iterators/2-async-iterators-generators/article.md Outdated Show resolved Hide resolved
1-js/12-generators-iterators/2-async-iterators-generators/article.md Outdated Show resolved Hide resolved
1-js/12-generators-iterators/2-async-iterators-generators/article.md Outdated Show resolved Hide resolved
1-js/12-generators-iterators/2-async-iterators-generators/article.md Outdated Show resolved Hide resolved
1-js/12-generators-iterators/2-async-iterators-generators/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@danilolmc
Copy link
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team March 4, 2024 21:06
nazarepiedady
nazarepiedady approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@nazarepiedady nazarepiedady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve it.

@nazarepiedady nazarepiedady merged commit 7c6f74b into javascript-tutorial:master Mar 6, 2024
1 check passed
@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nazarepiedady nazarepiedady nazarepiedady approved these changes

@Peruibeloko Peruibeloko Peruibeloko approved these changes

@jonnathan-ls jonnathan-ls Awaiting requested review from jonnathan-ls

@murillorossetti murillorossetti Awaiting requested review from murillorossetti

@odsantos odsantos Awaiting requested review from odsantos

Assignees
No one assigned
Labels
needs +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danilolmc @javascript-translate-bot @nazarepiedady @Peruibeloko