SWITCHYARD-2009 #671
SWITCHYARD-2009 #671
Conversation
|
Here's an alternative approach for consideration. I haven't tested it, but there's enough there to get the idea across. https://github.com/kcbabo/core/tree/SWITCHYARD-2009 |
| // Maintain old functionality | ||
| if (_config.isPreferLocal()){ | ||
| if ((_registry != null) | ||
| && (_registry.hasLocalEndpoint(serviceName)) && (_loadBalancer != null)) { |
There was a problem hiding this comment.
Can you explain this logic?
If you select preferLocal, no matter if clustered or not this executes (Fine)
then if there is a localEndpoint for the service and load balance strategy do a remote otherwise a local?
I think that it should be something like:
- if there is localendpoint invokeLocal, otherwise invokeRemote.
Also, now that this is a RemoteInvoker, you could optimize that if the "LoadBalanceStrategy" gets you a local endpoint, invokeLocal.
There was a problem hiding this comment.
You are making a comment on code I didn't write. :-) This looks to be a comment on the code you initially submitted. At least that's what GitHub is showing me with your comment.
There was a problem hiding this comment.
I'm a fucker. Tiredness fooled me.
I'm cool with your changes, in fact, very cool as it will always make local calls if prefer local and service is covered, otherwise it will load balance.
|
I think you clicked on the commit that you submitted as part of the PR. My commit is not associated with a PR at this point other than the link to my branch that I provided above. |
As discussed here: https://community.jboss.org/message/870119.
Also a pull request for core