-
Notifications
You must be signed in to change notification settings - Fork 1
Random thoughts
Right now, the background script broadcasts to all tabs that the hold key is pressed. Perhaps we should just have the tabs not know about whether the hold key is being pressed or not if this is a "browser level" (applies to the browser and not just any individual tab) state rather than state local to each tab.
On the other hand, if the tabs do not know if the hold key is being pressed or not, then they just need to send all keypresses over to the background script because they cannot differentiate what is a hotkey or not. This is not necessarily a bad thing.
In the end, I think we should keep the state that the hold key is being pressed at the tab-level (even though the state is actually browser level) because we intend on having the tabs give visual indication that the hold key is being pressed down. This means that the tabs will have to know when the hold key is being pressed down or not.
I think we should do this because people who take a cursory glance at our website might be mistaken to think that our extension just makes new tabs and that's it. Also, the gif's kinda make the page feel messy to me.