Change the command name to 'java.project.updateSettings'

Signed-off-by: Sheng Chen <sheche@microsoft.com>
jdneo · May 18, 2024 · f6598ad · f6598ad
1 parent bcedc83
commit f6598ad
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/org.eclipse.jdt.ls.core/plugin.xml b/org.eclipse.jdt.ls.core/plugin.xml
@@ -86,7 +86,7 @@
                   id="java.project.updateClassPaths">
             </command>
             <command
-                  id="java.project.updateProjectOptions">
+                  id="java.project.updateSettings">
             </command>
             <command
                   id="java.project.isTestFile">

diff --git a/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/JDTDelegateCommandHandler.java b/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/JDTDelegateCommandHandler.java
@@ -105,10 +105,10 @@ public Object executeCommand(String commandId, List<Object> arguments, IProgress
 					ProjectCommand.updateClasspaths(projectUri, entries.getClasspathEntries(), monitor);
 					return null;
 				}
-				case "java.project.updateProjectOptions": {
+				case "java.project.updateSettings": {
 					String projectUri = (String) arguments.get(0);
 					Map<String, Object> options = JSONUtility.toModel(arguments.get(1), Map.class);
-					ProjectCommand.updateProjectOptions(projectUri, options);
+					ProjectCommand.updateProjectSettings(projectUri, options);
 					return null;
 				}
 				case "java.project.isTestFile":

diff --git a/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/commands/ProjectCommand.java b/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/commands/ProjectCommand.java
@@ -718,7 +718,7 @@ public JdkUpdateResult(boolean success, String message) {
 	 * @throws CoreException
 	 * @throws URISyntaxException
 	 */
-	public static void updateProjectOptions(String projectUri, Map<String, Object> options) throws CoreException, URISyntaxException {
+	public static void updateProjectSettings(String projectUri, Map<String, Object> options) throws CoreException, URISyntaxException {
 		IJavaProject javaProject = getJavaProjectFromUri(projectUri);
 		IProject project = javaProject.getProject();
 		for (Map.Entry<String, Object> entry : options.entrySet()) {

diff --git a/...clipse.jdt.ls.tests/src/org/eclipse/jdt/ls/core/internal/commands/ProjectCommandTest.java b/...clipse.jdt.ls.tests/src/org/eclipse/jdt/ls/core/internal/commands/ProjectCommandTest.java
@@ -461,7 +461,7 @@ public void testUpdateMavenProfiles() throws Exception {
 
 		Map<String, Object> updateOptions = new HashMap<>();
 		updateOptions.put(KEY, "my profile");
-		ProjectCommand.updateProjectOptions(uriString, updateOptions);
+		ProjectCommand.updateProjectSettings(uriString, updateOptions);
 
 		options = ProjectCommand.getProjectSettings(uriString, settingKeys);
 		assertEquals("my profile", options.get(KEY));