Add option to configure credential_source #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsedlace
force-pushed
the
credential_source
branch
from
a3c22a4
to
4d8f3bd
Compare
|
@jdowning any comments? |
jdowning
reviewed
Sep 10, 2019
| $aws_secret_access_key = undef, | ||
| $role_arn = undef, | ||
| $source_profile = undef, | ||
| Optional[Enum['Environment', 'Ec2InstanceMetadata', 'EcsContainer']] $credential_source = undef, |
There was a problem hiding this comment.
I am not familiar with this syntax. Could you link me to the docs?
jdowning
reviewed
Sep 10, 2019
| @@ -108,6 +114,10 @@ | |||
| $group_real = $group | |||
| } | |||
|
|
|||
| if ($source_profile != undef and $credential_source != undef) { | |||
| fail('aws cli profile cannot contain both source_profile and credential_source config option') | |||
There was a problem hiding this comment.
It might be good to have a spec to test this. Do you think you could add one?
|
@jsedlace Looks good. I left a couple of comments. Let me know what you think. |
|
@jdowning it took more than 2 years, but I want to finish what was started - can you please check now? I've added tests and links to puppet syntax |
|
Hello @jdowning , can you please check if this PR makes sense for you? |
|
Hey @jdowning, is this something you can use in the main branch? |
|
Howdy @jdowning , can this code be of any use in the project? We use it from our branch for quite a while and it serves well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jdowning I've seen you have there opened issue for this feature and we need it as well now.