Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "parameters" in scripted pipeline job #495

Merged

Conversation

reinholdfuereder
Copy link
Contributor

Inspired by #298 and #460 where I initially claimed that the "string" interceptor is not ideal -- that I want to take back now.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Copy link
Contributor

@nre-ableton nre-ableton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two questions

@reinholdfuereder
Copy link
Contributor Author

Thanks for your feedback: Actually I did not use these boolean parameters any further in the pipeline script (like the string parameter), because I actually only wanted to show/test the callstack output of (a) "parameters" with different parameter types ("string" interceptor for string-typed parameter), and (b) also in combination with "withCredentials" -- where I was not happen with side effects between "string" interceptor initially (maybe with JenkinsPipelineUnit v1.8; but maybe I back then already lacked the insight from my comment #460 (comment))

So no, I did not use the boolean parameters on purpose. But if you want me to use it, I can certainly add that.

@nre-ableton
Copy link
Contributor

Ok, thanks for the clarification.

@nre-ableton nre-ableton merged commit c237a48 into jenkinsci:master Mar 2, 2022
@reinholdfuereder reinholdfuereder deleted the scripted_pipeline_parameters branch March 2, 2022 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants