Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EA] Add support for categories separated by a brace #994

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

Stargazer1998
Copy link
Contributor

Current implementation does not take warnings in the following structure into account:
[2024-01-05 10:52:27.3199] Warn - Out parameters ('Model_ptr_2345') are not supported. Please use 'return' or 'inout' parameters; {98CF1FE6-EC9C-43f1-e476-40EFCD63cA8D}
For this purpose only the WARNING_PATTERN was modified to capture new category.

Testing done

The current change was tested by adding additional test case to the EmbeddedEngineerParserTest file.
Tests were executed using [warnings-ng-plugin-devenv] development environment.
Screenshots of the test results:
test_1

test_2

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@Stargazer1998 Stargazer1998 changed the title Modifications for new Warning Category enhancement for new WarningCategory Jan 5, 2024
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ed0035e) 93.08% compared to head (9b2b0e9) 93.08%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #994   +/-   ##
=========================================
  Coverage     93.08%   93.08%           
  Complexity     2386     2386           
=========================================
  Files           347      347           
  Lines          6612     6612           
  Branches        689      689           
=========================================
  Hits           6155     6155           
  Misses          257      257           
  Partials        200      200           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uhafner uhafner added the bug Bugs or performance problems label Jan 9, 2024
@uhafner uhafner changed the title enhancement for new WarningCategory Add support for categories separated by a brace Jan 9, 2024
@uhafner uhafner changed the title Add support for categories separated by a brace [EA] Add support for categories separated by a brace Jan 9, 2024
@uhafner uhafner merged commit 38c2f61 into jenkinsci:main Jan 9, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs or performance problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants