Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EA] Add support of multi-lines error messages #995

Merged
merged 28 commits into from
Jan 11, 2024

Conversation

Stargazer1998
Copy link
Contributor

Current implementation is unable to provide a complete description for the errors composed of multiple lines. An example is as:

[2023-04-10 12:04:22.1045] Error - Error loading plugins from: C:\file1\idc\sample_ext.x64.dll
File name: 'file:///C:\AA\BB\System.Text.Json.dll' ---> System.NotSupportedException: An attempt was made to load an
(moree lines!)
at System.Reflection.Assembly.LoadFrom(String assemblyFile)
at A.A1.a(String , Predicate1 , Object[] )
at A.A1.A(String , Predicate1 , Object[] )

Testing done

The current change was tested by adding additional test case to the EmbeddedEngineerParserTest file.
Tests were executed using [warnings-ng-plugin-devenv] development environment.
Screenshots of the test results:
test_1
test_2

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@uhafner uhafner added the bug Bugs or performance problems label Jan 9, 2024
@uhafner uhafner changed the title bugfix to take multiple lines of error masseges Add support of multi-lines error messages Jan 9, 2024
@uhafner
Copy link
Member

uhafner commented Jan 9, 2024

Can you please have a look at the style checks?

@uhafner uhafner changed the title Add support of multi-lines error messages [EA] Add support of multi-lines error messages Jan 9, 2024
uhafner and others added 5 commits January 9, 2024 12:06
…ning_style

[EA] Add support for categories separated by a brace
Bumps [kentaro-m/auto-assign-action](https://github.com/kentaro-m/auto-assign-action) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/kentaro-m/auto-assign-action/releases)
- [Commits](kentaro-m/auto-assign-action@v1.2.5...v1.2.6)

---
updated-dependencies:
- dependency-name: kentaro-m/auto-assign-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps `slf4j.version` from 2.0.10 to 2.0.11.

Updates `org.slf4j:slf4j-api` from 2.0.10 to 2.0.11

Updates `org.slf4j:jul-to-slf4j` from 2.0.10 to 2.0.11

---
updated-dependencies:
- dependency-name: org.slf4j:slf4j-api
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.slf4j:jul-to-slf4j
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@Stargazer1998
Copy link
Contributor Author

Stargazer1998 commented Jan 10, 2024

Can you please have a look at the style checks?
Related issues have been corrected.

…j.version-2.0.11

Bump slf4j.version from 2.0.10 to 2.0.11
…ions/kentaro-m/auto-assign-action-1.2.6

Bump kentaro-m/auto-assign-action from 1.2.5 to 1.2.6
@uhafner
Copy link
Member

uhafner commented Jan 11, 2024

Thanks! Can you please merge with main (or rebase)?

correct number of instances
resolve conflicts
resolve checkStyle issue
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ed0035e) 93.08% compared to head (422eee4) 93.08%.
Report is 10 commits behind head on main.

Files Patch % Lines
...hafner/analysis/parser/EmbeddedEngineerParser.java 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #995      +/-   ##
============================================
- Coverage     93.08%   93.08%   -0.01%     
- Complexity     2386     2395       +9     
============================================
  Files           347      349       +2     
  Lines          6612     6623      +11     
  Branches        689      690       +1     
============================================
+ Hits           6155     6165      +10     
  Misses          257      257              
- Partials        200      201       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uhafner uhafner merged commit 03cfa28 into jenkinsci:main Jan 11, 2024
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs or performance problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants