Skip to content

Commit

Permalink
Bump version of maven-setup to v4.5.
Browse files Browse the repository at this point in the history
  • Loading branch information
uhafner committed Nov 25, 2023
1 parent a35e4f2 commit c09a094
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
check-latest: true
cache: 'maven'
- name: Set up Maven
uses: stCarolas/setup-maven@v4
uses: stCarolas/setup-maven@v4.5
with:
maven-version: 3.9.5
- name: Build with Maven
Expand Down
3 changes: 0 additions & 3 deletions src/main/java/edu/hm/hafner/coverage/SafeFraction.java
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@

import org.apache.commons.lang3.math.Fraction;

import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;

import static edu.hm.hafner.coverage.Percentage.*;

/**
Expand Down Expand Up @@ -33,7 +31,6 @@ public SafeFraction(final Fraction fraction) {
* @param denominator
* the denominator of the fraction
*/
@SuppressFBWarnings("CT_CONSTRUCTOR_THROW")
public SafeFraction(final int numerator, final int denominator) {
if (denominator == 0) {
throw new IllegalArgumentException(TOTALS_ZERO_MESSAGE);

Check warning on line 36 in src/main/java/edu/hm/hafner/coverage/SafeFraction.java

View check run for this annotation

ci.jenkins.io / SpotBugs

CT_CONSTRUCTOR_THROW

NORMAL: Exception thrown in class edu.hm.hafner.coverage.SafeFraction at new edu.hm.hafner.coverage.SafeFraction(int, int) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.
Raw output
no message found
Expand Down

0 comments on commit c09a094

Please sign in to comment.