Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump edu.hm.hafner:codingstyle-pom from 3.39.0 to 3.40.0 #61

Merged
merged 3 commits into from
Dec 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<parent>
<groupId>edu.hm.hafner</groupId>
<artifactId>codingstyle-pom</artifactId>
<version>3.39.0</version>
<version>3.40.0</version>
<relativePath />
</parent>

Expand Down
1 change: 0 additions & 1 deletion src/main/java/edu/hm/hafner/coverage/Metric.java
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,6 @@ private boolean hasCoverage(final Node node, final Metric metric) {
return node.getValue(metric)
.filter(value -> ((Coverage) value).getCovered() > 0)
.isPresent();

}

@Override
Expand Down
1 change: 0 additions & 1 deletion src/test/java/edu/hm/hafner/coverage/MutationTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@ void shouldBuildAndAddToModule() {
assertThat(moduleNode.getAllFileNodes().get(0))
.hasName("Class.java")
.hasMutations(mutationBuilder.build());

}

@Test
Expand Down
3 changes: 0 additions & 3 deletions src/test/java/edu/hm/hafner/coverage/NodeTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,6 @@ void shouldReturnAllNodesOfSpecificMetricType() {
assertThat(parent.getAll(FILE))
.hasSize(2)
.containsOnly(childOfChildOne, childOfChildTwo);

}

private static Coverage getCoverage(final Node node, final Metric metric) {
Expand Down Expand Up @@ -325,7 +324,6 @@ void shouldKeepChildNodesAfterCombiningReportWithSamePackage() {
Node combinedReport = module.merge(sameModule);

assertThat(combinedReport.getChildren().get(0)).hasOnlyChildren(fileToKeep, otherFileToKeep);

}

@Test
Expand Down Expand Up @@ -704,7 +702,6 @@ void shouldMergeWithDuplicateAndDifferentNames() {
.hasMetric(CONTAINER);

assertThat(merged.getChildren()).hasSize(2);

}

@Test
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@

@DefaultLocale("en")
class CoberturaParserTest extends AbstractParserTest {

private static final int COVERED_LINES = 20 + 17 + 6 + 12 + 7;
private static final int MISSED_LINES = 8 + 1 + 1 + 10;

Expand Down Expand Up @@ -255,7 +254,6 @@ void shouldReadCoberturaAggregation() {
assertThat(p.getAll(CLASS)).extracting(Node::getName).contains("env.ts");
}
);

}

@Test @Issue("jenkinsci/code-coverage-api-plugin#473")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -106,5 +106,4 @@ private ModuleNode readReport(final String fileName, final CoverageParser parser
throw new AssertionError(e);
}
}

}