Skip to content

Commit

Permalink
Merge pull request #747 from jenkinsci/revert-744-app-org-different-f…
Browse files Browse the repository at this point in the history
…rom-repo-org

Revert "Do not enforce GitHub app to comes from the same org as the repo org. The GH app can come from another org as log as it is installed in the org with the target git repo there is no security issue"
  • Loading branch information
jtnord authored Nov 15, 2023
2 parents 6b61a1d + 901162c commit 6bfb8df
Showing 1 changed file with 3 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -326,6 +326,9 @@ public String getUsername() {
@NonNull
public synchronized GitHubAppCredentials withOwner(@NonNull String owner) {
if (this.owner != null) {
if (!owner.equals(this.owner)) {
throw new IllegalArgumentException("Owner mismatch: " + this.owner + " vs. " + owner);

Check warning on line 330 in src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubAppCredentials.java

View check run for this annotation

ci.jenkins.io / Code Coverage

Not covered lines

Lines 329-330 are not covered by tests
}
return this;
}
if (byOwner == null) {
Expand Down

0 comments on commit 6bfb8df

Please sign in to comment.