[JENKINS-58942] Honor -Djenkins.hook.url=… if defined #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsandell
approved these changes
Aug 15, 2019
bitwiseman
previously requested changes
Aug 21, 2019
|
There are some WireMock tests in this repo. I am not sure how to write new ones using the current idiom of record/playback. Did not see anything related to hook registration. |
jglick
changed the title
bitwiseman
reviewed
Sep 11, 2019
| public static void register(GitHub hub, String orgName) throws IOException { | ||
| String rootUrl = Jenkins.getActiveInstance().getRootUrl(); | ||
| String rootUrl = System.getProperty("jenkins.hook.url"); |
There was a problem hiding this comment.
@jglick Does that automatically convert from the JENKINS_HOOK_URL env value as well?
There was a problem hiding this comment.
No. I switched to the system property
- for consistency with other configuration in Jenkins
- because for my purposes it must be mutable inside the JVM, which environment variables are not (AFAIK)
In the long term, this probably belongs in JenkinsLocationConfiguration, but requiring such a core dependency would make this potentially unmergeable for months, so I thought it would be acceptable to start with an experimental system property.
bitwiseman
approved these changes
Sep 11, 2019
|
see #310 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JENKINS-58942 for discussion. Open to alternate configuration mechanisms; this is just the simplest thing I could think of. I have tested this using a webhook forwarding service by creating an organization folder, verifying that the alternate base URL was used when registering the hook, and verifying that hook deliveries succeed and trigger responses such as starting builds.