-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-61290] hard to see why a branch was not inspected - log them #284
Open
jimklimov
wants to merge
22
commits into
jenkinsci:master
Choose a base branch
from
jimklimov:log-ignored-branches
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
1bb3d66
Problem: [JENKINS-61290] hard to see why a branch was not inspected
jimklimov 402482b
BranchDiscoveryTrait.java : reduce isExcluded() logging to head.toStr…
jimklimov 48848cf
BranchDiscoveryTrait.java: use the SCM API TaskListener to log into t…
jimklimov 588f891
Add mock data to test discovery of branches with or without PRs opene…
jimklimov 7a33c3f
BranchDiscoveryTrait.java: add a newline after logging the excluded b…
jimklimov 6bf938d
Merge remote-tracking branch 'upstream/master' into log-ignored-branc…
jimklimov edad8dd
BranchDiscoveryTrait.java : port the bit-field description comment fr…
jimklimov eaea9e9
BranchDiscoveryTrait.java : prune unneded blank line
jimklimov 9f09397
Merge branch 'master' into log-ignored-branches
jimklimov 2b0163e
Merge branch 'master' into log-ignored-branches
jimklimov 5f7c21b
GitHubNotificationRequest.java: fix @see tag syntax
jimklimov 5e35af3
Merge branch 'master' into log-ignored-branches
jimklimov aa1bf7f
Merge branch 'task/formatting-base' into log-ignored-branches
bitwiseman 5fb18a8
Apply autoformatting
bitwiseman e5f915b
Merge remote-tracking branch 'upstream/master' into log-ignored-branches
bitwiseman 31e1f76
Merge branch 'master' into log-ignored-branches
jimklimov 5749a22
Merge branch 'master' into log-ignored-branches
jimklimov 810eaf3
Merge branch 'master' into log-ignored-branches
jimklimov 0cb1f9b
Merge branch 'master' into log-ignored-branches
jimklimov 3c34f67
Merge remote-tracking branch 'upstream/master' as of 2023-08-26 into …
jimklimov eecfdf2
BranchDiscoveryTrait: "mvn spotless:apply" formatting to the source code
jimklimov f36f658
Merge branch 'master' into log-ignored-branches
jimklimov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
355 changes: 355 additions & 0 deletions
355
src/test/resources/api/PRs/_files/body-yolo-pulls-open-pr-from-branch-226.json
Large diffs are not rendered by default.
Oops, something went wrong.
345 changes: 345 additions & 0 deletions
345
src/test/resources/api/PRs/_files/body-yolo-pulls-open-pr-from-branch-listing.json
Large diffs are not rendered by default.
Oops, something went wrong.
104 changes: 104 additions & 0 deletions
104
...st/resources/api/branches/_files/body-yolo-branches-with-pr-from-branch-branchHotfix.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,104 @@ | ||
{ | ||
"name": "hotfix/BUGID-123456", | ||
"commit": { | ||
"sha": "b2e9d15d8311409d1adaeb139eeac0a8b436f5d8", | ||
"node_id": "MDY6Q29tbWl0NzY0OTczNDA6YjJlOWQxNWQ4MzExNDA5ZDFhZGFlYjEzOWVlYWMwYThiNDM2ZjVkOA==", | ||
"commit": { | ||
"author": { | ||
"name": "Some Contributor", | ||
"email": "contributor@somemail.org", | ||
"date": "2018-02-26T13:27:01Z" | ||
}, | ||
"committer": { | ||
"name": "GitHub", | ||
"email": "noreply@github.com", | ||
"date": "2018-02-26T13:27:01Z" | ||
}, | ||
"message": "Quickly work around some problems", | ||
"tree": { | ||
"sha": "747f9b7dc5aa53ae1741caab8f8cb20a577c1c64", | ||
"url": "https://api.github.com/repos/cloudbeers/yolo/git/trees/747f9b7dc5aa53ae1741caab8f8cb20a577c1c64" | ||
}, | ||
"url": "https://api.github.com/repos/cloudbeers/yolo/git/commits/b2e9d15d8311409d1adaeb139eeac0a8b436f5d8", | ||
"comment_count": 0, | ||
"verification": { | ||
"verified": true, | ||
"reason": "valid", | ||
"signature": "-----BEGIN PGP SIGNATURE-----\n\nPGP==HASH==\n-----END PGP SIGNATURE-----\n", | ||
"payload": "tree 747f9b7dc5aa53ae1741caab8f8cb20a577c1c64\nparent 097b9948c911c706638ffb9f8af8056c9a9872da\nparent 4f76402ef5bfed3f56b22c6705b5052ac3f92e87\nauthor Some Contributor <contributor@somemail.org> 1519651621 +0100\ncommitter GitHub <noreply@github.com> 1519651621 +0100\n\nQuickly work around some problems" | ||
} | ||
}, | ||
"url": "https://api.github.com/repos/cloudbeers/yolo/commits/b2e9d15d8311409d1adaeb139eeac0a8b436f5d8", | ||
"html_url": "https://github.com/cloudbeers/yolo/commit/b2e9d15d8311409d1adaeb139eeac0a8b436f5d8", | ||
"comments_url": "https://api.github.com/repos/cloudbeers/yolo/commits/b2e9d15d8311409d1adaeb139eeac0a8b436f5d8/comments", | ||
"author": { | ||
"login": "somecontrib", | ||
"id": 209336, | ||
"node_id": "MDQ6VXNlcjE5Mzg3NDQx", | ||
"avatar_url": "https://avatars1.githubusercontent.com/u/209336?v=4", | ||
"gravatar_id": "", | ||
"url": "https://api.github.com/users/somecontrib", | ||
"html_url": "https://github.com/somecontrib", | ||
"followers_url": "https://api.github.com/users/somecontrib/followers", | ||
"following_url": "https://api.github.com/users/somecontrib/following{/other_user}", | ||
"gists_url": "https://api.github.com/users/somecontrib/gists{/gist_id}", | ||
"starred_url": "https://api.github.com/users/somecontrib/starred{/owner}{/repo}", | ||
"subscriptions_url": "https://api.github.com/users/somecontrib/subscriptions", | ||
"organizations_url": "https://api.github.com/users/somecontrib/orgs", | ||
"repos_url": "https://api.github.com/users/somecontrib/repos", | ||
"events_url": "https://api.github.com/users/somecontrib/events{/privacy}", | ||
"received_events_url": "https://api.github.com/users/somecontrib/received_events", | ||
"type": "User", | ||
"site_admin": false | ||
}, | ||
"committer": { | ||
"login": "web-flow", | ||
"id": 19864447, | ||
"node_id": "MDQ6VXNlcjE5ODY0NDQ3", | ||
"avatar_url": "https://avatars3.githubusercontent.com/u/19864447?v=4", | ||
"gravatar_id": "", | ||
"url": "https://api.github.com/users/web-flow", | ||
"html_url": "https://github.com/web-flow", | ||
"followers_url": "https://api.github.com/users/web-flow/followers", | ||
"following_url": "https://api.github.com/users/web-flow/following{/other_user}", | ||
"gists_url": "https://api.github.com/users/web-flow/gists{/gist_id}", | ||
"starred_url": "https://api.github.com/users/web-flow/starred{/owner}{/repo}", | ||
"subscriptions_url": "https://api.github.com/users/web-flow/subscriptions", | ||
"organizations_url": "https://api.github.com/users/web-flow/orgs", | ||
"repos_url": "https://api.github.com/users/web-flow/repos", | ||
"events_url": "https://api.github.com/users/web-flow/events{/privacy}", | ||
"received_events_url": "https://api.github.com/users/web-flow/received_events", | ||
"type": "User", | ||
"site_admin": false | ||
}, | ||
"parents": [ | ||
{ | ||
"sha": "097b9948c911c706638ffb9f8af8056c9a9872da", | ||
"url": "https://api.github.com/repos/cloudbeers/yolo/commits/097b9948c911c706638ffb9f8af8056c9a9872da", | ||
"html_url": "https://github.com/cloudbeers/yolo/commit/097b9948c911c706638ffb9f8af8056c9a9872da" | ||
}, | ||
{ | ||
"sha": "4f76402ef5bfed3f56b22c6705b5052ac3f92e87", | ||
"url": "https://api.github.com/repos/cloudbeers/yolo/commits/4f76402ef5bfed3f56b22c6705b5052ac3f92e87", | ||
"html_url": "https://github.com/cloudbeers/yolo/commit/4f76402ef5bfed3f56b22c6705b5052ac3f92e87" | ||
} | ||
] | ||
}, | ||
"_links": { | ||
"self": "https://api.github.com/repos/cloudbeers/yolo/branches/hotfix/BUGID-123456", | ||
"html": "https://github.com/cloudbeers/yolo/tree/hotfix/BUGID-123456" | ||
}, | ||
"protected": true, | ||
"protection": { | ||
"enabled": true, | ||
"required_status_checks": { | ||
"enforcement_level": "everyone", | ||
"contexts": [ | ||
"continuous-integration/jenkins/pr-head", | ||
"continuous-integration/jenkins/pr-merge", | ||
"continuous-integration/travis-ci" | ||
] | ||
} | ||
}, | ||
"protection_url": "https://api.github.com/repos/cloudbeers/yolo/branches/hotfix/BUGID-123456/protection" | ||
} |
104 changes: 104 additions & 0 deletions
104
...t/resources/api/branches/_files/body-yolo-branches-with-pr-from-branch-branchRelease.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,104 @@ | ||
{ | ||
"name": "release/version-132", | ||
"commit": { | ||
"sha": "a5223ef8db4f717400489f42007ef73c6ce6dab7", | ||
"node_id": "MDY6Q29tbWl0NzY0OTczNDA6YTUyMjNlZjhkYjRmNzE3NDAwNDg5ZjQyMDA3ZWY3M2M2Y2U2ZGFiNw==", | ||
"commit": { | ||
"author": { | ||
"name": "Release Manager", | ||
"email": "stephenc@somemail.com", | ||
"date": "2018-09-19T13:14:30Z" | ||
}, | ||
"committer": { | ||
"name": "GitHub", | ||
"email": "noreply@github.com", | ||
"date": "2018-09-19T13:14:30Z" | ||
}, | ||
"message": "Merge pull request #145 from stephenc/branchRelease-backports", | ||
"tree": { | ||
"sha": "5f8e3d0f46ba4b071f543a921e34879b017ad479", | ||
"url": "https://api.github.com/repos/cloudbeers/yolo/git/trees/5f8e3d0f46ba4b071f543a921e34879b017ad479" | ||
}, | ||
"url": "https://api.github.com/repos/cloudbeers/yolo/git/commits/a5223ef8db4f717400489f42007ef73c6ce6dab7", | ||
"comment_count": 0, | ||
"verification": { | ||
"verified": true, | ||
"reason": "valid", | ||
"signature": "-----BEGIN PGP SIGNATURE-----\n\nPGP=HASH==\n-----END PGP SIGNATURE-----\n", | ||
"payload": "tree 5f8e3d0f46ba4b071f543a921e34879b017ad479\nparent 2734e2ba489ce3b9fdba21e0ea1a7e2576ee9aeb\nparent 3d1abda5673d995df0278b6216b179156c30ff54\nauthor Release Manager <stephenc@somemail.com> 1537362870 +0200\ncommitter GitHub <noreply@github.com> 1537362870 +0200\n\nMerge pull request #145 from stephenc/branchRelease-backports" | ||
} | ||
}, | ||
"url": "https://api.github.com/repos/cloudbeers/yolo/commits/a5223ef8db4f717400489f42007ef73c6ce6dab7", | ||
"html_url": "https://github.com/cloudbeers/yolo/commit/a5223ef8db4f717400489f42007ef73c6ce6dab7", | ||
"comments_url": "https://api.github.com/repos/cloudbeers/yolo/commits/a5223ef8db4f717400489f42007ef73c6ce6dab7/comments", | ||
"author": { | ||
"login": "stephenc", | ||
"id": 209336, | ||
"node_id": "MDQ6VXNlcjkyMTE5Nw==", | ||
"avatar_url": "https://avatars1.githubusercontent.com/u/209336?v=4", | ||
"gravatar_id": "", | ||
"url": "https://api.github.com/users/stephenc", | ||
"html_url": "https://github.com/stephenc", | ||
"followers_url": "https://api.github.com/users/stephenc/followers", | ||
"following_url": "https://api.github.com/users/stephenc/following{/other_user}", | ||
"gists_url": "https://api.github.com/users/stephenc/gists{/gist_id}", | ||
"starred_url": "https://api.github.com/users/stephenc/starred{/owner}{/repo}", | ||
"subscriptions_url": "https://api.github.com/users/stephenc/subscriptions", | ||
"organizations_url": "https://api.github.com/users/stephenc/orgs", | ||
"repos_url": "https://api.github.com/users/stephenc/repos", | ||
"events_url": "https://api.github.com/users/stephenc/events{/privacy}", | ||
"received_events_url": "https://api.github.com/users/stephenc/received_events", | ||
"type": "User", | ||
"site_admin": false | ||
}, | ||
"committer": { | ||
"login": "web-flow", | ||
"id": 19864447, | ||
"node_id": "MDQ6VXNlcjE5ODY0NDQ3", | ||
"avatar_url": "https://avatars3.githubusercontent.com/u/19864447?v=4", | ||
"gravatar_id": "", | ||
"url": "https://api.github.com/users/web-flow", | ||
"html_url": "https://github.com/web-flow", | ||
"followers_url": "https://api.github.com/users/web-flow/followers", | ||
"following_url": "https://api.github.com/users/web-flow/following{/other_user}", | ||
"gists_url": "https://api.github.com/users/web-flow/gists{/gist_id}", | ||
"starred_url": "https://api.github.com/users/web-flow/starred{/owner}{/repo}", | ||
"subscriptions_url": "https://api.github.com/users/web-flow/subscriptions", | ||
"organizations_url": "https://api.github.com/users/web-flow/orgs", | ||
"repos_url": "https://api.github.com/users/web-flow/repos", | ||
"events_url": "https://api.github.com/users/web-flow/events{/privacy}", | ||
"received_events_url": "https://api.github.com/users/web-flow/received_events", | ||
"type": "User", | ||
"site_admin": false | ||
}, | ||
"parents": [ | ||
{ | ||
"sha": "2734e2ba489ce3b9fdba21e0ea1a7e2576ee9aeb", | ||
"url": "https://api.github.com/repos/cloudbeers/yolo/commits/2734e2ba489ce3b9fdba21e0ea1a7e2576ee9aeb", | ||
"html_url": "https://github.com/cloudbeers/yolo/commit/2734e2ba489ce3b9fdba21e0ea1a7e2576ee9aeb" | ||
}, | ||
{ | ||
"sha": "3d1abda5673d995df0278b6216b179156c30ff54", | ||
"url": "https://api.github.com/repos/cloudbeers/yolo/commits/3d1abda5673d995df0278b6216b179156c30ff54", | ||
"html_url": "https://github.com/cloudbeers/yolo/commit/3d1abda5673d995df0278b6216b179156c30ff54" | ||
} | ||
] | ||
}, | ||
"_links": { | ||
"self": "https://api.github.com/repos/cloudbeers/yolo/branches/release/version-132", | ||
"html": "https://github.com/cloudbeers/yolo/tree/release/version-132" | ||
}, | ||
"protected": true, | ||
"protection": { | ||
"enabled": true, | ||
"required_status_checks": { | ||
"enforcement_level": "everyone", | ||
"contexts": [ | ||
"continuous-integration/jenkins/pr-head", | ||
"continuous-integration/jenkins/pr-merge", | ||
"continuous-integration/travis-ci" | ||
] | ||
} | ||
}, | ||
"protection_url": "https://api.github.com/repos/cloudbeers/yolo/branches/release/version-132/protection" | ||
} |
97 changes: 97 additions & 0 deletions
97
...st/resources/api/branches/_files/body-yolo-branches-with-pr-from-branch-branchWithPR.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,97 @@ | ||
{ | ||
"name": "branchWithPR", | ||
"commit": { | ||
"sha": "8b62d23190bf5210b5688ef62534897bb730aeb7", | ||
"node_id": "MDY6Q29tbWl0NzY0OTczNDA6OGI2MmQyMzE5MGJmNTIxMGI1Njg4ZWY2MjUzNDg5N2JiNzMwYWViNw==", | ||
"commit": { | ||
"author": { | ||
"name": "stephenc", | ||
"email": "stephenc@somemail.com", | ||
"date": "2020-03-06T13:15:29Z" | ||
}, | ||
"committer": { | ||
"name": "stephenc", | ||
"email": "stephenc@somemail.com", | ||
"date": "2020-03-06T14:34:52Z" | ||
}, | ||
"message": "Minor code cleanup\n\nSigned-off-by: stephenc <stephenc@somemail.com>", | ||
"tree": { | ||
"sha": "806bfa680bcc0f384935ac3a56f51c8b7334f18e", | ||
"url": "https://api.github.com/repos/cloudbeers/yolo/git/trees/806bfa680bcc0f384935ac3a56f51c8b7334f18e" | ||
}, | ||
"url": "https://api.github.com/repos/cloudbeers/yolo/git/commits/8b62d23190bf5210b5688ef62534897bb730aeb7", | ||
"comment_count": 0, | ||
"verification": { | ||
"verified": true, | ||
"reason": "valid", | ||
"signature": "-----BEGIN PGP SIGNATURE-----\n\nPGP==HASH==\n-----END PGP SIGNATURE-----", | ||
"payload": "tree 806bfa680bcc0f384935ac3a56f51c8b7334f18e\nparent be5d76394128d512458d736add63f8a67411cba0\nauthor stephenc <stephenc@somemail.com> 1583500529 +0100\ncommitter stephenc <stephenc@somemail.com> 1583505292 +0100\n\nMinor code cleanup\n\nSigned-off-by: stephenc <stephenc@somemail.com>\n" | ||
} | ||
}, | ||
"url": "https://api.github.com/repos/cloudbeers/yolo/commits/8b62d23190bf5210b5688ef62534897bb730aeb7", | ||
"html_url": "https://github.com/cloudbeers/yolo/commit/8b62d23190bf5210b5688ef62534897bb730aeb7", | ||
"comments_url": "https://api.github.com/repos/cloudbeers/yolo/commits/8b62d23190bf5210b5688ef62534897bb730aeb7/comments", | ||
"author": { | ||
"login": "stephenc", | ||
"id": 209336, | ||
"node_id": "MDQ6VXNlcjk4NzI5Njk=", | ||
"avatar_url": "https://avatars1.githubusercontent.com/u/209336?v=4", | ||
"gravatar_id": "", | ||
"url": "https://api.github.com/users/stephenc", | ||
"html_url": "https://github.com/stephenc", | ||
"followers_url": "https://api.github.com/users/stephenc/followers", | ||
"following_url": "https://api.github.com/users/stephenc/following{/other_user}", | ||
"gists_url": "https://api.github.com/users/stephenc/gists{/gist_id}", | ||
"starred_url": "https://api.github.com/users/stephenc/starred{/owner}{/repo}", | ||
"subscriptions_url": "https://api.github.com/users/stephenc/subscriptions", | ||
"organizations_url": "https://api.github.com/users/stephenc/orgs", | ||
"repos_url": "https://api.github.com/users/stephenc/repos", | ||
"events_url": "https://api.github.com/users/stephenc/events{/privacy}", | ||
"received_events_url": "https://api.github.com/users/stephenc/received_events", | ||
"type": "User", | ||
"site_admin": false | ||
}, | ||
"committer": { | ||
"login": "stephenc", | ||
"id": 209336, | ||
"node_id": "MDQ6VXNlcjk4NzI5Njk=", | ||
"avatar_url": "https://avatars1.githubusercontent.com/u/209336?v=4", | ||
"gravatar_id": "", | ||
"url": "https://api.github.com/users/stephenc", | ||
"html_url": "https://github.com/stephenc", | ||
"followers_url": "https://api.github.com/users/stephenc/followers", | ||
"following_url": "https://api.github.com/users/stephenc/following{/other_user}", | ||
"gists_url": "https://api.github.com/users/stephenc/gists{/gist_id}", | ||
"starred_url": "https://api.github.com/users/stephenc/starred{/owner}{/repo}", | ||
"subscriptions_url": "https://api.github.com/users/stephenc/subscriptions", | ||
"organizations_url": "https://api.github.com/users/stephenc/orgs", | ||
"repos_url": "https://api.github.com/users/stephenc/repos", | ||
"events_url": "https://api.github.com/users/stephenc/events{/privacy}", | ||
"received_events_url": "https://api.github.com/users/stephenc/received_events", | ||
"type": "User", | ||
"site_admin": false | ||
}, | ||
"parents": [ | ||
{ | ||
"sha": "be5d76394128d512458d736add63f8a67411cba0", | ||
"url": "https://api.github.com/repos/cloudbeers/yolo/commits/be5d76394128d512458d736add63f8a67411cba0", | ||
"html_url": "https://github.com/cloudbeers/yolo/commit/be5d76394128d512458d736add63f8a67411cba0" | ||
} | ||
] | ||
}, | ||
"_links": { | ||
"self": "https://api.github.com/repos/cloudbeers/yolo/branches/branchWithPR", | ||
"html": "https://github.com/cloudbeers/yolo/tree/branchWithPR" | ||
}, | ||
"protected": false, | ||
"protection": { | ||
"enabled": false, | ||
"required_status_checks": { | ||
"enforcement_level": "off", | ||
"contexts": [ | ||
|
||
] | ||
} | ||
}, | ||
"protection_url": "https://api.github.com/repos/cloudbeers/yolo/branches/branchWithPR/protection" | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are all of these new test resource files actually used? I do not see any new (Java) test code. Perhaps these are left over from some commits years earlier, or does some existing test actually fail without them?