fix(#141): make file transfers work again

jeremyckahn · Dec 5, 2024 · 60be4fb · 60be4fb
1 parent 8c86140
commit 60be4fb
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/src/components/Room/useRoomFileShare.ts b/src/components/Room/useRoomFileShare.ts
@@ -118,8 +118,8 @@ export function useRoomFileShare({
     setSharedFiles(files)
     setIsFileSharingEnabled(false)
 
-    if (typeof shellContext.roomId !== 'string') {
-      throw new Error('shellContext.roomId is not a string')
+    if (!shellContext.roomId) {
+      throw new Error('shellContext.roomId is not a non-empty string')
     }
 
     const alertText =

diff --git a/src/components/Shell/PeerList.tsx b/src/components/Shell/PeerList.tsx
@@ -71,6 +71,7 @@ export const PeerList = ({
             peer={peer}
             peerConnectionTypes={peerConnectionTypes}
             peerAudioChannels={peerAudioChannels}
+            roomId={roomId ?? ''}
           />
         ))}
         {peerList.length === 0 &&

diff --git a/src/components/Shell/PeerListItem.tsx b/src/components/Shell/PeerListItem.tsx
@@ -39,6 +39,7 @@ interface PeerListItemProps {
   peer: Peer
   peerConnectionTypes: Record<string, PeerConnectionType>
   peerAudioChannels: Record<string, AudioChannel>
+  roomId: string
 }
 
 const verificationStateDisplayMap = {
@@ -65,6 +66,7 @@ export const PeerListItem = ({
   peer,
   peerConnectionTypes,
   peerAudioChannels,
+  roomId,
 }: PeerListItemProps) => {
   const theme = useTheme()
   const { getUserSettings } = useContext(SettingsContext)
@@ -194,7 +196,7 @@ export const PeerListItem = ({
             mt={1}
             overflow="auto"
           >
-            <Room roomId="" userId={userId} targetPeerId={peer.peerId} />
+            <Room roomId={roomId} userId={userId} targetPeerId={peer.peerId} />
           </Box>
         </DialogContent>
         <DialogActions>