Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test failure in Python 3.14a #107

Merged

Conversation

dogukancagatay
Copy link
Contributor

@dogukancagatay dogukancagatay commented Nov 14, 2024

Due to recent changes in argparse error message construction the test
that checks for the non-existing split algorithm was failing.
python/cpython#117766

Fixed with a lenient error string check with an additional dynamic algorithm
check.

In 3.14, the argparse starts using str() instead of repr(), which changes the following error output.

"(choose from 'duration_based_chunks', 'least_duration')"

to

"(choose from duration_based_chunks, least_duration)"

Due to recent changes in argparse error message construction the test
that is checking for the non-existing split algorithm was failing.
python/cpython#117766

Fixed with a lenient error string check with additional dynamic algorithm
check.
Copy link
Owner

@jerry-git jerry-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jerry-git jerry-git merged commit fb9af7e into jerry-git:master Nov 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants