[runx] Add support for fetching private GitHub release assets #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savil
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
LGTM. I also did a rudimentary test by pointing Devbox repo to this PR's changes for runx, and it seemed to work fine.
@loreto @mikeland73 @LucilleH @gcurtis I have limited experience with runx code so tagging you to take a second look. I'll merge this in a short while.
|
Looks good to me on the github part 👍 |
|
@mikael-lindstrom thank you! |
mikeland73
added a commit
to jetify-com/devbox
that referenced
this pull request
Aug 15, 2024
## Summary Uses newest version of runx (jetify-com/opensource#368) cc: @mikael-lindstrom ## How was it tested? ``` rm -rf ~/Library/Caches/runx/pkgs/mvdan devbox run fmt # which requires mvdan/gofumpt ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allows runx to download release assets from private repositories, fixes jetify-com/devbox#2223
downloadto set the GitHub tokenAcceptheader toapplication/octet-streamto get the binary instead of json metadata for the assetHow was it tested?
I have tested the
runxcli locally with and withoutRUNX_GITHUB_API_TOKENset. With the environment variable the release asset is downloaded correctly from private repositories. Without the environment variable public repositories works fine and private returns404.I also build
devboxlocally and tested with and withoutDEVBOX_GITHUB_API_TOKENset and it works the same as running therunxcli directly.