[runx] Allow unknown file types #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This tweaks the logic in #401 to allow unknown file types if there are no known file types in the list of released artifacts. This is needed because some releases don't have file types at all (e.g. https://github.com/mvdan/gofumpt/releases). We try to return a known archive, otherwise we just return the last artifact that matches the platform (if any)
Note: this is a revert to how the logic behaved before #401 but keeps the artifact name improvements from that PR.
cc: @edorizzardi
How was it tested?
runx --install mvdan/gofumpt