Add more traces and get logs even if no failure

jfdenise · May 28, 2024 · b41e659 · b41e659
1 parent fae0d7f
commit b41e659
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/.github/workflows/test-permissions.yml b/.github/workflows/test-permissions.yml
@@ -33,7 +33,6 @@ jobs:
           mvn clean install -Dts.bootable -Dtest=org.jboss.as.test.manualmode.secman.PermissionsDeploymentTestCase -Dtest.num.sleep=6
         shell: bash
       - name: Find reports
-        if: failure()
         run: |
           {
             echo 'SUREFIRE_REPORTS<<EOF'
@@ -42,7 +41,6 @@ jobs:
           } >> "$GITHUB_ENV"
         shell: bash
       - name: Find server logs
-        if: failure()
         run: |
           {
             echo 'SERVER_LOGS<<EOF'
@@ -52,13 +50,11 @@ jobs:
         shell: bash
       - name: Upload Test Reports on Failure
         uses: actions/upload-artifact@v4
-        if: failure()
         with:
           name: surefire-reports-${{ matrix.os }}-${{ matrix.java }}
           path: ${{ env.SUREFIRE_REPORTS }}
       - name: Upload Server Logs on Failure
         uses: actions/upload-artifact@v4
-        if: failure()
         with:
           name: server-logs-${{ matrix.os }}-${{ matrix.java }}
           path: ${{ env.SERVER_LOGS }}
diff --git a/bootable-jar/boot/src/main/java/org/wildfly/core/jar/boot/CleanupProcessor.java b/bootable-jar/boot/src/main/java/org/wildfly/core/jar/boot/CleanupProcessor.java
@@ -66,7 +66,7 @@ public FileVisitResult visitFile(final Path file, final BasicFileAttributes attr
                         Files.delete(file);
                         int num = holder.get(0);
                         if (num != 0) {
-                            System.out.println("Sleeping for failure");
+                            System.out.println("Sleeping for failure after having deleted " + file);
                             try {
                                 Thread.sleep(2000);
                             } catch (InterruptedException ex) {
@@ -76,6 +76,8 @@ public FileVisitResult visitFile(final Path file, final BasicFileAttributes attr
                             num -=1;
                             holder.set(0, num);
                         }
+                    } else {
+                        System.out.println("CLEANUP PROCESS IGNORING MARKER FILE " + cleanupMarker);
                     }
                 } catch (IOException e) {
                     if (log) {

diff --git a/...mode/src/test/java/org/jboss/as/test/manualmode/secman/PermissionsDeploymentTestCase.java b/...mode/src/test/java/org/jboss/as/test/manualmode/secman/PermissionsDeploymentTestCase.java
@@ -119,13 +119,16 @@ public void testWithConfiguredMaxBootThreads() throws Exception {
     @Test
     public void testWithoutConfiguredMaxBootThreads() throws Exception {
         for (int i = 0; i < 1000; i++) {
+            System.out.println("TEST START THE CONTAINER");
             container.start();
             try {
                 addDeploymentScanner(modelControllerClient, 1000, false, true);
                 this.testInvalidPermissionsXmlDeployment("test-permissions-xml-without-max-boot-threads.jar");
             } finally {
                 removeDeploymentScanner(modelControllerClient);
+                System.out.println("TEST STOP THE CONTAINER");
                 container.stop();
+                 System.out.println("TEST STOPPED THE CONTAINER");
             }
         }
     }