-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add force revocable parameter to token endpoints #175
feat: add force revocable parameter to token endpoints #175
Conversation
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request |
I have read the CLA Document and I hereby sign the CLA |
recheck |
2 similar comments
recheck |
recheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The API request payload needs to use this new config value. See https://github.com/jfrog/vault-plugin-secrets-artifactory/blob/master/artifactory.go#L149
Can you elaborate please? I am setting the request's ForceRevocable value to the config's value if it's not null. |
@georgeskill You're right, you did! I missed it during review. |
Thanks for approving. How can I get the CLA Assistant action to pass? Am I missing a step to get it to pass? |
@georgeskill You are good to go with CLA. The GitHub action is not very smart 😄 . I have an urgent task to take care first today so I'll merge this tomorrow. |
@georgeskill If you wish to try to sign CLA again, please include only the CLA message. I think the last time you also included the 'rechecking' and that confused the GitHub Action. |
I have read the CLA Document and I hereby sign the CLA |
recheck |
@georgeskill Don't worry about CLA GitHub Action. You clearly have signed it 😄 |
Hello. I went ahead and added the
force_revocable
parameter as an optional parameter. By default,use_expiring_tokens
will still setforce_revocable
totrue
, unless it is explicitly given. This should solve my issue at #174. My access tokens metadata indicated they were not revocable, but also had a value inexpires_in
."I have read the CLA Document and I hereby sign the CLA"