Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add force revocable parameter to token endpoints #175

Merged

Conversation

georgeskill
Copy link

Hello. I went ahead and added the force_revocable parameter as an optional parameter. By default, use_expiring_tokens will still set force_revocable to true, unless it is explicitly given. This should solve my issue at #174. My access tokens metadata indicated they were not revocable, but also had a value in expires_in.

"I have read the CLA Document and I hereby sign the CLA"

Copy link

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

@georgeskill
Copy link
Author

georgeskill commented Apr 17, 2024

I have read the CLA Document and I hereby sign the CLA

@gr-david-snowdon
Copy link

recheck

2 similar comments
@georgeskill
Copy link
Author

recheck

@alexhung
Copy link
Member

recheck

Copy link
Member

@alexhung alexhung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API request payload needs to use this new config value. See https://github.com/jfrog/vault-plugin-secrets-artifactory/blob/master/artifactory.go#L149

path_config.go Show resolved Hide resolved
@alexhung alexhung added the enhancement New feature or request label Apr 17, 2024
@georgeskill
Copy link
Author

The API request payload needs to use this new config value. See https://github.com/jfrog/vault-plugin-secrets-artifactory/blob/master/artifactory.go#L149

Can you elaborate please? I am setting the request's ForceRevocable value to the config's value if it's not null.

@alexhung
Copy link
Member

@georgeskill You're right, you did! I missed it during review.

@georgeskill
Copy link
Author

@georgeskill You're right, you did! I missed it during review.

Thanks for approving. How can I get the CLA Assistant action to pass? Am I missing a step to get it to pass?

@alexhung
Copy link
Member

@georgeskill You are good to go with CLA. The GitHub action is not very smart 😄 . I have an urgent task to take care first today so I'll merge this tomorrow.

@alexhung
Copy link
Member

@georgeskill If you wish to try to sign CLA again, please include only the CLA message. I think the last time you also included the 'rechecking' and that confused the GitHub Action.

@georgeskill
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@georgeskill
Copy link
Author

recheck

@alexhung
Copy link
Member

@georgeskill Don't worry about CLA GitHub Action. You clearly have signed it 😄

@alexhung alexhung merged commit 4626b70 into jfrog:master Apr 18, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants