Fix: videojs.getComponent is not a function / videojs is not defined #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aka videojs is not defined
Adds import video.js into each component, which eliminates the following error when
using video-http-source-selector with webpack:
```
videojs-http-source-selector.es.js:36 Uncaught TypeError: videojs.getComponent is not a function
at Module.<anonymous> (videojs-http-source-selector.es.js:36)
at Module../node_modules/videojs-http-source-selector/dist/videojs-http-source-selector.es.js (videojs-http-source-selector.es.js:264)
```
This change also resolves compiled output in dist/ mixing up use of `videojs` and `videojs$1`.
|
Thanks @zarqman |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
videojs.getComponent is not a function/videojs is not defined.Imports video.js into each component, which eliminates the following error (and similar variations) when using video-http-source-selector with webpack:
This change also resolves compiled output in dist/ mixing up use of
videojsandvideojs$1.Fixes #1 and succeeds #3.
(Only src/ included as I assume you'd prefer to rebuild dist/ yourself, but can add that to the PR if you prefer.)