Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(getAccessibilityCSSSelector): Finding the matching aria-label #652

Conversation

emrahcom
Copy link
Contributor

This PR is related with jitsi/jitsi-meet#14997
It fixes the test to check the related PR correctly.

Aria-label is not static for the participant button after the update. So, looking for the whole match doesn't work. This PR allows to find the matching tag by checking the match at the beginning.

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@emrahcom
Copy link
Contributor Author

Wrong account. I will create a new PR

@emrahcom emrahcom closed this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants