Skip to content

Commit

Permalink
fix: Avoid overwriting the max resolution requested by the tile-view. (
Browse files Browse the repository at this point in the history
…#7320)

Part of [1] replaces a `setPreferredVideoQuality` call with a
`setMaxReceiverVideoQuality` call. The change was part of a bigger
changeset that adds logic that tries to adjust the max based on reduced
ui turned on or off and allow to set prefered through the config.

However, by calling `setMaxReceiverVideoQuality` instead of
`setPreferredVideoQuality`, the new feature overrides the lower
resolution requested by tile-view earlier in some occasions.

This PR reverts back to using `setPreferredVideoQuality` instead of
`setMaxReceiverVideoQuality` as this achieves the same result without
overwriting the max set by the tile-view.

NOTE that this is a quick-fix and all the handling related to setting
the receive resolution will be reworked soon.

[1]: 7d51373
  • Loading branch information
gpolitis authored Jul 15, 2020
1 parent 1790c71 commit 11fd536
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions react/features/conference/middleware.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {
VIDEO_QUALITY_LEVELS,
conferenceLeft,
getCurrentConference,
setMaxReceiverVideoQuality
setPreferredVideoQuality
} from '../base/conference';
import { hideDialog, isDialogOpen } from '../base/dialog';
import { setActiveModalId } from '../base/modal';
Expand All @@ -33,7 +33,7 @@ MiddlewareRegistry.register(store => next => action => {
dispatch(setFilmstripEnabled(!reducedUI));

dispatch(
setMaxReceiverVideoQuality(
setPreferredVideoQuality(
reducedUI
? VIDEO_QUALITY_LEVELS.LOW
: VIDEO_QUALITY_LEVELS.HIGH));
Expand Down

0 comments on commit 11fd536

Please sign in to comment.